-
Notifications
You must be signed in to change notification settings - Fork 0
fix dates #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dates #13
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR attempts to fix date handling in Google Calendar integration by replacing ISO 8601 UTC timestamps with local datetime strings paired with explicit timezone parameters. The changes include adding a timezone parameter to the createCalendar function and implementing a formatDateTimeLocal helper function.
Key changes:
- Introduced
formatDateTimeLocalfunction to format dates without timezone suffix - Replaced
toISOString()calls withformatDateTimeLocal()for event start/end times - Added timezone parameter to
createCalendarfunction with "UTC" default - Improved user-facing message during schedule analysis
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/server/services/google-calendar.ts | Added formatDateTimeLocal function, replaced toISOString() with formatDateTimeLocal() for event times, added timezone parameter to createCalendar |
| src/server/api/routers/schedule.ts | Extracted timezone variable for reuse, passed timezone to createCalendar |
| src/components/upload-zone.tsx | Moved eslint-disable comment position, enhanced analyzing message with user guidance |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.